Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated palette button hiding code #178

Merged

Conversation

marcustyphoon
Copy link
Collaborator

User-facing changes

  • None, mostly.

Technical explanation

The code in question, used to hide the nonfunctional-with-this-extension "change palette" button in the UI:

  • Doesn't work, as the capitalization of its selector is wrong (at some point I guess it changed to Change palette)
  • Isn't needed, as this button doesn't exist in the current version of the UI. I don't know of any currently updated scripts that revert the UI in a way that brings back the code path that produces the button in question, either, though the code remains.
  • Logs an error in the dashboard occasionally (I did not look into reproducing this reliably, due to the previous bullet points).

Therefore, this removes it.

Issues this closes

n/a

@AprilSylph AprilSylph linked an issue Apr 18, 2024 that may be closed by this pull request
@AprilSylph AprilSylph self-requested a review April 18, 2024 08:33
@AprilSylph AprilSylph merged commit 1806efb into AprilSylph:master Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Change palette" button is not hidden
2 participants