Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accent colors not applying #185

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

marcustyphoon
Copy link
Collaborator

User-facing changes

Fixes accent colors not being affected by the extension due to a Tumblr code change that I didn't really look into.

Technical explanation

Applies what used to be an accent override to the deprecated-accent CSS variable as well; this results in no changes being needed to custom palettes as well as built-in palette data.

I assume the change to this variable name could be a sign of more things to come that could be problematic for custom palettes still working without tweaks/migration? But if so, that can be a problem for later.

Issues this closes

Resolves #183, resolves #182

@AprilSylph AprilSylph self-requested a review May 24, 2024 10:12
@marcustyphoon
Copy link
Collaborator Author

Ah, I see. It looks like --accent is being repurposed into a part of a system of colors with variations, and that in that system the variables are colors rather than numerical triplets?

That I can tell, these new colors appear to be hardcoded; if that's the case I assume we don't want to touch them, as overriding only some would lead to inconsistency. Thus, if my interpretation is right we should be sure to only modify --deprecated-accent, and decline to modify --accent? I should make a second tweak to new-xkit/XKit#2141 if so.

@AprilSylph AprilSylph merged commit bb0c956 into AprilSylph:master Jun 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants