Use native palettes when possible #194
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcustyphoon
force-pushed
the
native-palettes
branch
from
6f5085c
to
b563976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MVP of code that changes the actual Tumblr palette when the user selects one of Tumblr's, rather than overriding the colors. Prevents mismatched colors from all of the new design system variables when selecting a Tumblr palette. Could be used to set the Tumblr palette to e.g. True Blue when a Palettes for Tumblr builtin or custom user palette is selected.
Drawbacks: I mean, look, you can see the diff. Hey, anyone want to add
window.tumblr.changePalette? That doesn't sound like a waste of development time at allllllllllThat being said, I do think the path for the future of this extension is worth discussing.
Testing steps