Implement automatic light/dark mode palettes #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only contains selection UI. I haven't bothered to look into the details of how to use media queries in the styles we're injecting atEdit: Ah, cool, that wasn't bad at all.document_start, if that's possible. Would be nice for@supportsin #206 though!This implements a palette option that lets the user select separate palettes for light and dark mode that, dependent on support from their OS and browser, will be automatically applied.
I couldn't decide between a checkbox that adds a second select element or having one of the options in the main select element be for this mode... well, I mean, I guess I did decide, insofar as I implemented one of the options. But you know what I mean: I could be convinced that the checkbox is better (more visible, which could be a good or bad thing for a niche feature).
Resolves #200.