Implement Stream Transaction Api. #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscJockeyDJ
force-pushed
the
streamTransaction
branch
2 times, most recently
from
5264cfd
to
d4afd34
Compare
DiscJockeyDJ
force-pushed
the
streamTransaction
branch
2 times, most recently
from
ba4ef23
to
1ae7d18
Compare
|
Stream Transactions are now working as expected. Added good number of cases to test each scenarios. Let me know if anything is missing. |
DiscJockeyDJ
force-pushed
the
streamTransaction
branch
3 times, most recently
from
3b34da2
to
2ed04e2
Compare
|
Added stream transaction support to,
|
DiscJockeyDJ
force-pushed
the
streamTransaction
branch
from
1bdf307
to
587b9ee
Compare
For Arango 3.4, filter and exclude the StreamTransaction tests using Xunit Trait. fix ArangoDB-Community#322
DiscJockeyDJ
force-pushed
the
streamTransaction
branch
from
587b9ee
to
e5ac8eb
Compare
|
Only TransctionApi changes are now in the PR. |
DiscoPYF
requested changes
Jun 17, 2021
There was a problem hiding this comment.
@DiscJockeyDJ Thank you for this pull request. I spotted a few things which I think should be addressed before merging. Happy to discuss any of them.
|
Added commit to address the above suggestions 👍 |
Refactored the TransactionApiClient and its test class. Created a new class StreamTransactionResponse. fix ArangoDB-Community#322
DiscJockeyDJ
force-pushed
the
streamTransaction
branch
from
c7e2aff
to
2455685
Compare
DiscoPYF
requested changes
Jun 23, 2021
arangodb-net-standard/TransactionApi/Models/StreamTransactionResponse.cs
Outdated
Show resolved
Hide resolved
arangodb-net-standard/TransactionApi/Models/StreamTransactionBody.cs
Outdated
Show resolved
Hide resolved
arangodb-net-standard/TransactionApi/Models/PostTransactionBody.cs
Outdated
Show resolved
Hide resolved
arangodb-net-standard/TransactionApi/Models/StreamTransactionResult.cs
Outdated
Show resolved
Hide resolved
arangodb-net-standard.Test/TransactionApi/TransactionApiClientTest.cs
Outdated
Show resolved
Hide resolved
arangodb-net-standard.Test/TransactionApi/TransactionApiClientTest.cs
Outdated
Show resolved
Hide resolved
Refactored TransactionApiClientTest and StreamTransactionBody class. fix ArangoDB-Community#322
|
Added commit to address the above suggestions 👍 |
DiscoPYF
approved these changes
Jul 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the Stream Transaction Api using the documentation from Arangodb
https://www.arangodb.com/docs/3.6/http/transaction-stream-transaction.html
Even though the API calls work, the collections gets updated once the transactions begins (or) before committing/aborting.
Added few test cases to check that.