Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.10: ArangoSearch changes #422

Merged
merged 3 commits into from
Oct 11, 2022
Merged

3.10: ArangoSearch changes #422

merged 3 commits into from
Oct 11, 2022

Conversation

tjoubert
Copy link
Contributor

@tjoubert tjoubert commented Sep 14, 2022 •
edited
Loading

@tjoubert tjoubert self-assigned this Sep 14, 2022
@DiscoPYF DiscoPYF mentioned this pull request Oct 8, 2022
Closed
DiscoPYF
DiscoPYF approved these changes Oct 9, 2022
View reviewed changes
Copy link
Collaborator

@DiscoPYF DiscoPYF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've approved but left some minor comments. I'll let you decide if you want to address them.

arangodb-net-standard/AnalyzerApi/Models/AnalyzerProperties.cs Outdated Show resolved Hide resolved
arangodb-net-standard/ViewApi/Models/ViewDetails.cs Outdated Show resolved Hide resolved
arangodb-net-standard/ViewApi/Models/SearchAliasIndex.cs Show resolved Hide resolved
arangodb-net-standard/ViewApi/Models/SearchAliasIndex.cs Outdated Show resolved Hide resolved
@tjoubert
Copy link
Contributor Author

Looks good. I've approved but left some minor comments. I'll let you decide if you want to address them.

@DiscoPYF, thanks for review and approval. I've done the changes and merging this one.

@tjoubert tjoubert merged commit 3deb20e into master Oct 11, 2022
@tjoubert tjoubert deleted the feature3.10/DE-352-arangosearch-changes branch October 11, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiscoPYF DiscoPYF DiscoPYF approved these changes

@rossmills99 rossmills99 Awaiting requested review from rossmills99

Assignees

@tjoubert tjoubert

Labels
ArangoDB 3.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjoubert @DiscoPYF