Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arv_dom_document_get_url is always NULL #829

Closed
eudoxos opened this issue Oct 15, 2023 · 2 comments · Fixed by #835
Closed

arv_dom_document_get_url is always NULL #829

eudoxos opened this issue Oct 15, 2023 · 2 comments · Fixed by #835
Labels
1. bug Problems, incorrect behavior or appearance 5. Genicam Issue in Genicam implementation

Comments

@eudoxos
Copy link
Contributor

eudoxos commented Oct 15, 2023

Describe the bug
There is a function to retrieve URL of the genicam XML: arv_dom_document_get_url; it returns ArvDomDocumentPrivate's url attribute, assigned in arv_dom_document_new_from_url.

This codepath is not currently used at all, though. Instead, arv_gc_new receives already loaded XML; the loading happens in _load_genicam which only returns the XML content but does not store its URL (obtained with arv_gv_device_read_memory at ARV_GVBS_XML_URL_SIZE). That is why arv_dom_document_get_url return NULL (as far as I understand).

Expected behavior
arv_dom_document_get_url returns URL (such as Local:genicam.xml;123;456, 123 being address and 456 size) which can be parsed and used to retrieve the XML from memory again (for GigeV, USB and Fake cameras).

Platform description:

  • Aravis version: git
  • OS: Mint 21.1
  • Hardware: x86_64

Additional context
This is needed for the GenTL provider so that it does not duplicate code from other parts of Aravis. GenTL consumers download and interpret the XML themselves, and use URL to request them via memory access.

@EmmanuelP EmmanuelP added 1. bug Problems, incorrect behavior or appearance 5. Genicam Issue in Genicam implementation labels Oct 21, 2023
@EmmanuelP
Copy link
Contributor

Please try #835.

eudoxos pushed a commit to eudoxos/aravis that referenced this issue Nov 4, 2023
@eudoxos
Copy link
Contributor Author

eudoxos commented Nov 4, 2023

Excellent, #835 really helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. bug Problems, incorrect behavior or appearance 5. Genicam Issue in Genicam implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants