added get/set register node value #833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmanuelP
requested changes
Nov 2, 2023
Comment on lines
+2853
to
+2882
| arv_camera_get_register (ArvCamera *camera, const char *feature,guint64 length, void* value, GError **error) | ||
| { | ||
| ArvCameraPrivate *priv = arv_camera_get_instance_private (camera); | ||
|
|
||
| g_return_if_fail (ARV_IS_CAMERA (camera)); | ||
|
|
||
| arv_device_get_register_feature_value (priv->device, feature, length, value, error); | ||
| } | ||
|
|
||
| /** | ||
| * arv_camera_get_register_length: | ||
| * @camera: a #ArvCamera | ||
| * @feature: feature name | ||
| * @error: a #GError placeholder | ||
| * | ||
| * Returns: the length of register value, 0 if not available | ||
| * | ||
| * Since: | ||
| */ | ||
|
|
||
| guint64 | ||
| arv_camera_get_register_length (ArvCamera *camera, const char *feature, GError **error) | ||
| { | ||
| ArvCameraPrivate *priv = arv_camera_get_instance_private (camera); | ||
|
|
||
| g_return_val_if_fail (ARV_IS_CAMERA (camera), 0); | ||
|
|
||
| return arv_device_get_register_feature_length (priv->device, feature, error); | ||
| } | ||
|
|
There was a problem hiding this comment.
I would simplify the API here, and make get_register allocate a buffer and return the buffer length, and suppress get_register_length.
There was a problem hiding this comment.
And rename get_register to dup_register, which makes clear the data must be freed after use.
Comment on lines
+383
to
+389
| if (error == NULL){ | ||
| printf("Content of %s =", tokens[0]); | ||
| for( int i = 0; i < length; i++){ | ||
| if ( i%8 == 0){ | ||
| printf("\n\t"); | ||
| } | ||
| printf("0x%02x ", *((buffer)+i)); |
There was a problem hiding this comment.
Use arv_g_string_append_hex_dump here.
Please format the output as:
GenDCDescriptor = 128 bytes@0x0900
01e0 c8 b7 89 b0 45 fa 3d 9d 8c e9 a7 33 46 85 1f 2c ....E.=....3F..,
...
Comment on lines
+836
to
+867
| void | ||
| arv_device_get_register_feature_value (ArvDevice *device, const char *feature, guint64 length, void* value, GError **error) | ||
| { | ||
| ArvGcNode *node; | ||
|
|
||
| node = _get_feature (device, ARV_TYPE_GC_REGISTER, feature, error); | ||
| if (node != NULL) | ||
| arv_gc_register_get (ARV_GC_REGISTER (node), value, length, error); | ||
| } | ||
|
|
||
| /** | ||
| * arv_device_get_register_feature_length: | ||
| * @device: a #ArvDevice | ||
| * @feature: feature name | ||
| * @error: a #GError placeholder | ||
| * | ||
| * Returns: the length of register value, 0 if not available | ||
| * | ||
| * Since: | ||
| */ | ||
|
|
||
| guint64 | ||
| arv_device_get_register_feature_length (ArvDevice *device, const char *feature, GError **error) | ||
| { | ||
| ArvGcNode *node; | ||
| node = _get_feature (device, ARV_TYPE_GC_REGISTER, feature, error); | ||
| if (node != NULL) | ||
| return arv_gc_register_get_length(ARV_GC_REGISTER (node), error); | ||
|
|
||
| return 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
Same remark here about the API simplification. In arvDevice, the get_register function should take care to check the buffer length value is lower than the maximum size (2^16), and return an error otherwise.
|
I have made the changes and merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented an API to set/get the value of the "Register-Type" node in order for the Aravis library to handle cameras in the GENDC data format in the future.
Currently, when using the arv-tool to display the GenDC descriptor, it appears as follows:
Note that
GNDC(0x47 0x4e 0x44 0x43) is the signature of GenDCDescriptor of the beginning of U3V payloadReference: https://www.emva.org/wp-content/uploads/GenICam_GenDC_v1_1.pdf