Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lufia2ac: switch to new options system #2289

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

el-u
Copy link
Collaborator

@el-u el-u commented Oct 10, 2023

What is this fixing or adding?

Moves the Lufia 2 Ancient Cave world to the new options system introduced in #993

How was this tested?

Generated a game with non-default option and verified that the option values are reflected in the spoiler log as well as in game.

Copy link
Collaborator

@alwaysintreble alwaysintreble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would prefer just using self.options instead of self.o, but since it's just a reference it's fine

@Berserker66 Berserker66 merged commit 63c7f1d into ArchipelagoMW:main Oct 15, 2023
12 checks passed
@el-u el-u deleted the lufia2ac-options branch October 15, 2023 03:01
@ThePhar ThePhar added the is: refactor/cleanup Improvements to code/output readability or organizization. label Oct 17, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: refactor/cleanup Improvements to code/output readability or organizization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants