The Witness: mypy compliance #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
affects: core
NewSoupVi
added
the
is: refactor/cleanup
github-actions
bot
added
the
waiting-on: peer-review
NewSoupVi
added
waiting-on: other
|
Update: Probably won't actually add my world to the list of files because the remaining errors are with core and the strategy seems to be "If there's something wrong with core that is stopping you from being mypy compliant, hopefully that'll motivate you to go and add typing to core", which it does not, for me. :D I'll still try to get this merged because I think it makes the Witness apworld better. |
Exempt-Medic
added
the
waiting-on: author
NewSoupVi
added
waiting-on: peer-review
Exempt-Medic
approved these changes
May 9, 2024
Berserker66
approved these changes
Jun 15, 2024
GameWyrm
pushed a commit
to GameWyrm/Archipelago-GW
that referenced
this pull request
Jul 4, 2024
* Make witness apworld mostly pass mypy * Fix all remaining mypy errors except the core ones * I'm a goofy stupid poopoo head * Two more fixes * ruff after merge * Mypy for new stuff * Oops * Stricter ruff rules (that I already comply with :3) * Deprecated ruff thing * wait no i lied * lol super nevermind * I can actually be slightly more specific * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two remaining errors I cannot solve without touching core (I believe).
This PR will be drafted for now until the mypy PR is merged / rejected / finalised.