Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noita: Do some cleanup to make mypy happy #3114

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Noita: Do some cleanup to make mypy happy #3114

merged 1 commit into from
Apr 13, 2024

Conversation

ScipioWright
Copy link
Collaborator

What is this fixing or adding?

This PR exists: #3107
So just doing a little clean up. It isn't everything mypy complained about, just the easy stuff.

How was this tested?

Ran gen.

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 7, 2024
nicholassaylor
nicholassaylor approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor type hints

@Exempt-Medic Exempt-Medic added the is: refactor/cleanup Improvements to code/output readability or organizization. label Apr 8, 2024
Exempt-Medic
Exempt-Medic approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine, just some type hinting

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 8, 2024
@Berserker66 Berserker66 merged commit feaae1d into ArchipelagoMW:main Apr 13, 2024
15 checks passed
@ScipioWright ScipioWright deleted the noita-mypy branch April 14, 2024 16:32
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@ScipioWright @EmilyV99
Noita: Do some cleanup to make mypy happy (ArchipelagoMW#3114)
47bac30
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@ScipioWright @EmilyV99
Noita: Do some cleanup to make mypy happy (ArchipelagoMW#3114)
9285b03
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@ScipioWright @qwint
Noita: Do some cleanup to make mypy happy (ArchipelagoMW#3114)
235f9ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berserker66 Berserker66 Berserker66 approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@nicholassaylor nicholassaylor nicholassaylor approved these changes

Assignees
No one assigned
Labels
is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScipioWright @Berserker66 @Exempt-Medic @nicholassaylor