Shivers: Add collect behavior option. #3854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
|
This is fine of course, but did you consider just putting this into the client somehow? I made it a dropdown in my client & my players really appreciate being able to switch collect behaviors mid-game (or like, mid-seed - they do have to relaunch the client, but yeah) |
Exempt-Medic
added
the
is: enhancement
|
@NewSoupVi I took the time to get feedback and poll players over 2 weeks and this is something that can get changed in the future if people end up wanting the flexibility to change on the fly. |
Co-authored-by: Scipio Wright <[email protected]>
|
World Maintainer: Looks good. |
ScipioWright
approved these changes
Aug 30, 2024
ScipioWright
added
waiting-on: core-review
NewSoupVi
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This adds a new option that has not affect on generation and is purely for client side behavior.
This enables the player to select how collection affects their world.
How was this tested?
I checked that the player option on webhost had the new options
If this makes graphical changes, please attach screenshots.