[PKMN RB] Adds slot data that tells the tracker V5 logic should be considered #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
is: enhancement
| @@ -703,6 +703,7 @@ def fill_slot_data(self) -> dict: | |||
| "require_pokedex": self.options.require_pokedex.value, | |||
| "area_1_to_1_mapping": self.options.area_1_to_1_mapping.value, | |||
| "blind_trainers": self.options.blind_trainers.value, | |||
| "v5_update": True | |||
There was a problem hiding this comment.
Suggested change
| "v5_update": True | |
| "v5_update": True, |
You should have a comma after the last line, so that if something is added later, the diff only shows a 1 line change instead of a 2 line change (like how this is a 1 line change because blind_trainers had a , at the end)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
Adds a flag to slot data that is just dummy-true so the poptracker can test for whether the slot data exists to apply 0.5.1 or 0.5.0 logic for Pokémon RB.
How was this tested?
Generated a game successfully. Connected with a Debug Pack, verified slot data was present.
If this makes graphical changes, please attach screenshots.
N/A