The Witness: Make Elevators Come To You an OptionSet #4000
Conversation
github-actions
bot
added
the
waiting-on: peer-review
NewSoupVi
added
the
is: enhancement
NewSoupVi
force-pushed
the
elevators_optionset
branch
from
1331503
to
75ee399
Compare
There was a problem hiding this comment.
LGTM, simple logic creating new entrances.
Since it turned from a toggle to an option set, might be a good idea to handle someone having it set to True or False (unless I missed that)
Either by adjusting True to just include all 3 of them, or a warning or something.
|
I'm still having it error, but the message should be clearer now |
|
Welp. Unfortunately, I already turned off my PC now, so I'll fix these unit tests tomorrow lol |
| # Used to be a toggle | ||
| @classmethod | ||
| def from_text(cls, text: str): | ||
| if text.lower() in {"off", "0", "false", "none", "null", "no"}: |
There was a problem hiding this comment.
null did not work before
| if text.lower() in {"off", "0", "false", "none", "null", "no"}: | |
| if text.lower() in {"off", "0", "false", "none", "no"}: |
There was a problem hiding this comment.
Huh, I copied this from the Toggle code
| @@ -279,12 +290,31 @@ class ChallengeLasers(Range): | |||
| default = 11 | |||
|
|
|||
|
|
|||
| class ElevatorsComeToYou(Toggle): | |||
| class ElevatorsComeToYou(OptionSet): | |||
There was a problem hiding this comment.
It may be a good idea to add the list of valid keys to the option description, this makes it clear what the options are even in the template yaml.
Exempt-Medic
added
waiting-on: author
Let's the player choose each bridge/elevator individually for elevators come to you.
This suffers a bit from OptionSets not allowing any kind of "random", but that can come in the future hopefully.
Also yay 4000 :)
Compatible client: https://github.com/NewSoupVi/The-Witness-Randomizer-for-Archipelago/releases/tag/v7.0.0p12
Tested: Unit tests