-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Witness: Add "Panel Keys" and "Obelisk Keys" item groups #4026
base: main
Are you sure you want to change the base?
Conversation
Would "Panels" be a more intuitive name for that group? Alternatively, it should probably be "Door Keys" so they all match. Also, is it intended that "Boat" is in the Panels group for these? |
Yes, but I might make a "Panels" location group, and I don't like the idea that those have the same name
Hmm, I'll think about it
Yes, Boat is a panel key since it unlocks panels. It just so happens that you add it to your game via a different option than shuffle_doors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Item groups gud, code looks fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments were addressed, the code looks good and the groups (checked the datapackage) are accurate
Right now, there is a Doors item group that contains everything that sort of acts like a door (i.e. it is unlocked by a singular "key"), and these items are all implemented the same in the code.
But for the player, there are really three types of """doors""": Doors, Panels, and Obelisks.
This PR splits the "Doors" item group into "Doors", "Panel Keys", and "Obelisk Keys".
The name "Panel Keys" was chosen because "Panels" might be a location group in the future, and the name makes more sense for that.
Tested:
Launched Webhost and glanced at datapackage