Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add silver Power Star item #9

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Aug 31, 2023

  1. Add "Alt Power Star" item

    This change adds item ID 0x69 (currently unused) which duplicates the data of the existing 0x6B "Goal Item (Multi/Power Star)" and changes the palette of the existing power star item to 0x02 (silver).  This is intended to allow differentiating progression items (gold stars) from non-progression items (silver stars) for other worlds.
    
    New hash: 7c9599a6ff33563b33178ab8e5a1dac8
    
    Example image: https://i.imgur.com/B2LUdFS.png
    krelbel committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    91c3dd6 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. Fix silver power star item get animation

    Fix a bug in the previous commit where the silver power star item in newitems.asm:.properties still used the gold power star palette, causing the "item get" animation to incorrectly show a gold power star upon picking up a silver power star.  Also updated comments for consistency with gold/silver power star terminology.
    
    Tested with a 2-player lttp/hollowknight multiworld verifying standing items look correct in and out of shops and picking up items animates correctly for both gold and silver power stars.
    
    The previous commit listed an outdated screenshot (with the colors reversed); the updated screenshot showing this feature is: https://i.imgur.com/iMPxzgw.png
    
    New ROM hash after this change: 8719f420b587adac8d3750792d46e5bd
    krelbel committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    b787b83 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. Configuration menu
    Copy the full SHA
    d4e0a9e View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Compress code for collection of Power Stars

    Adding handling for a new item to the ASM was causing that code it to overflow its banks. The code has been tweaked to fit into its allotted space, while still performing the same function.
    Kappatechy committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    ebe9ea9 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. Configuration menu
    Copy the full SHA
    c8b20ee View commit details
    Browse the repository at this point in the history