-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworks workflows to integrate release creation and trusted publishing in addition to testing and linting #35
Conversation
with: | ||
merge-multiple: true | ||
|
||
- name: Combine coverage and fail if it's <95% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Around here would be a great place to integrate codecov if ever desired
Seems like the pre-commit bot ran and changed a bunch of files. Maybe a little early? |
Yeah - probably should have a dedicated PR just to let precommit muck around with all the files. I can do that tomorrow, or you can do a precommit CI PR it and I'll merge. |
… both Github and PyPI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently not home so this is a half-review I quickly did on mobile. Will do a proper review tomorrow.
Also as a note, I only have squash merge turned on for any repos I manage, so you can save yourself time and not worry about commit history if you'd like. |
Not really sure that the link check thing is. Seems alright, except for all the resource warnings. |
Dang, that link check error is This just occurred within the past day, but it looks like they got annoyed with the sheer amount of HTTP requests coming from workflows... I'm tempted to say we wait a day and see if they backtrack on their decision. Otherwise, we might be forced to remove Maybe we can switch to |
Since it's not related to this pr, I'd prefer to keep it separate and merge into this. I probably won't have time for a bit to experiment |
I just experimented with it on another repo and linkspector is broken at the moment. We can just disable linkcheckmd temporarily. |
@stumpylog In terms of this new workflow, what is your proposed release process? This CI doesn't appear to have any events related to tag creation, so I've tried manually tagging a commit in |
On.push should be trigger by the pushing of a new tag. I can look at the co runs tomorrow from a computer |
I just tried a workaround that uses the Perhaps we need to add a on:
push:
branches:
- main
tags:
- "**" |
Looks like there's a I think either a |
These precise conditions works fine for me: https://github.com/stumpylog/gotenberg-client/blob/3ee137c559beffb9239b9dbe28ca4c1b0ca4b872/.github/workflows/ci.yml#L3-L8 and then https://github.com/stumpylog/gotenberg-client/blob/3ee137c559beffb9239b9dbe28ca4c1b0ca4b872/.github/workflows/ci.yml#L228-L231 I'm not sure what it could be. The name of the ref is correct. How are you creating it? Just |
I believe I had run |
Looking at the two runs which were named 2.1.0, both were triggered via a pull request from a branch. Currently, with on.push.branches set, the workflow will not run when a tag is pushed. See here. You would need to explicitly add |
Makes sense. I needed to specify a branch to avoid getting double-spammed with CI runs from my PRs. I'll need to manually add a |
Description
I always find the box view best:
Running against a normal commit: https://github.com/stumpylog/ServeStatic/actions/runs/10951878142
When run with a tag: https://github.com/stumpylog/ServeStatic/actions/runs/10951805566
An example release: https://github.com/stumpylog/ServeStatic/releases
basically, linting first, the testing the code, updating documentation, and if triggered via tag, creating a release and publishing to pypi. Some jobs could be combined, such as documentation being a single job which lints, build and deploys according to the Git ref.
Closes #34
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).