Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor problems on snow1 branch in io binary and pnetcdf implementation #2

Merged
merged 3 commits into from
May 4, 2021

Conversation

apcraig
Copy link

@apcraig apcraig commented Apr 18, 2021

PR checklist

  • Short (1 sentence) summary of your PR:
    Fix minor problems on snow1 branch in io binary and pnetcdf implementation
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    before had 49 failures, after none. Several results are not bit-for-bit in regression testing but that's a separate issue. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#6cf44dcb4bdaae6aa232e6b986328d13cb4d0cd7
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

This is a PR to a branch to fix a couple minor bugs.

It also updates the branch to the latest CICE-Consortium master

@eclare108213
Copy link

@apcraig explains the failing checks:
The CICE testing doesn't work in GHActions because it's missing the new Icepack code. When we're testing CICE+snow now, we're manually updating Icepack. The automated GHActions testing doesn't do that. This won't work until Icepack is updated on this branch of CICE.

I will merge this PR so that we can continue testing with up-to-date code and fix additional problems as they come up.

@eclare108213 eclare108213 merged commit 5c95294 into Arctic-InteRFACE:snow1 May 4, 2021
@apcraig apcraig deleted the snow1tc1 branch August 17, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants