This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Issues #5 - Added clear button and other smaller features #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added clear button to clear the search term * Added configuration to hide clear button showClearTextButton * Added bool hideSearchBoxDevider * Added popParentOnBackButton to navigate back on back buttonnot just out of the SearchBar
ArcticZeroo
suggested changes
Nov 23, 2017
| this.popParentOnBackButton = false, | ||
| this.showClearTextButton = false, | ||
| this.hideSearchBoxDevider = true}) { | ||
| if (controller == null) controller = new TextEditingController(); |
There was a problem hiding this comment.
Why not just use default parameter values for this?
| bool showClearTextButton; | ||
|
|
||
| /// This hides or shows the underline of the search text input field | ||
| bool hideSearchBoxDevider; |
There was a problem hiding this comment.
This is incorrectly spelled; should be "divider"
| this.colorBackButton = true, | ||
| this.closeOnSubmit = true | ||
| }); | ||
| /// This hides or shows the button on the right site of the text input field |
| /// Whether a search text is present. | ||
| bool _isSearchTextPresent = false; | ||
|
|
||
| // If this is true the Parent Route will be poped when the Back Button is used |
| /// | ||
| AppBar buildSearchBar(BuildContext context) { | ||
| ThemeData theme = Theme.of(context); | ||
| var theme = Theme.of(context); |
There was a problem hiding this comment.
This should be a ThemeData, Theme.of can't return anything else
| void beginSearch(context) { | ||
| ModalRoute.of(context).addLocalHistoryEntry(new LocalHistoryEntry( | ||
| onRemove: () { | ||
| if (!popParentOnBackButton) { |
There was a problem hiding this comment.
Shouldn't this be checking for true, not false?
|
closing due to inactivity |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #5
All changes should not affect the existing API and defaults