Skip to content
This repository has been archived by the owner on Dec 27, 2023. It is now read-only.

Updated InputDecorator properties, changed setState type #9

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Updated InputDecorator properties, changed setState type #9

merged 1 commit into from
Feb 7, 2018

Conversation

GRouslan
Copy link
Contributor

@GRouslan GRouslan commented Feb 5, 2018

  1. Basically hideDivider: true should now be border: null
    More info here: #Update InputDecorator et al flutter/flutter#13734
  2. Dart Analysis server complains about setState :

A function of type '(() → void) → void' can't be assigned to a location of type '(dynamic) → void'.

@@ -1,13 +1,12 @@
// Copyright (c) 2017, Spencer. All rights reserved. Use of this source code
// is governed by a BSD-style license that can be found in the LICENSE file.

import 'dart:async';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't the file fail to compile due to this line? Unless dart has changed significantly since the last time I used it, you need to import async to use the keyword async

Copy link
Contributor Author

@GRouslan GRouslan Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It compiles and works. "import 'dart:async';" is marked as unused import in Intellij Idea.

Dart VM version: 2.0.0-dev.19.0 (Fri Jan 19 08:01:12 2018 +0100) on "windows_x64"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to dart-lang/sdk#26162
the async keywords - async, await, yield are available without "import 'dart:async';" at least since Apr 1, 2016

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, alright! Guess when I wrote this my machine had an old version of dart. I am seeing the same behavior in IntelliJ.

@ArcticZeroo ArcticZeroo merged commit c938421 into ArcticZeroo:master Feb 7, 2018
@ArcticZeroo
Copy link
Owner

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants