Skip to content

Commit

Permalink
Add minLength: 1 to resourceGroupName paramters (Azure#4979)
Browse files Browse the repository at this point in the history 
This avoids an inscrutable error in the CLI if the user specifies an
empty resource group name.
  • Loading branch information
@mboersma @sarangan12
mboersma authored and sarangan12 committed Jan 4, 2019
1 parent 7c5ca6a commit a4368ac
Show file tree
Hide file tree
Showing 3 changed files with 115 additions and 46 deletions.
43 changes: 27 additions & 16 deletions ...source-manager/Microsoft.ContainerService/preview/2018-08-01-preview/managedClusters.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@
"in": "path",
"required": true,
"type": "string",
"minLength": 1,
"description": "The name of the resource group."
}
],
Expand Down Expand Up @@ -154,6 +155,7 @@
"in": "path",
"required": true,
"type": "string",
"minLength": 1,
"description": "The name of the resource group."
},
{
Expand Down Expand Up @@ -199,6 +201,7 @@
"in": "path",
"required": true,
"type": "string",
"minLength": 1,
"description": "The name of the resource group."
},
{
Expand Down Expand Up @@ -251,6 +254,7 @@
"in": "path",
"required": true,
"type": "string",
"minLength": 1,
"description": "The name of the resource group."
},
{
Expand Down Expand Up @@ -296,6 +300,7 @@
"in": "path",
"required": true,
"type": "string",
"minLength": 1,
"description": "The name of the resource group."
},
{
Expand Down Expand Up @@ -341,6 +346,7 @@
"in": "path",
"required": true,
"type": "string",
"minLength": 1,
"description": "The name of the resource group."
},
{
Expand Down Expand Up @@ -384,6 +390,7 @@
"in": "path",
"required": true,
"type": "string",
"minLength": 1,
"description": "The name of the resource group."
},
{
Expand Down Expand Up @@ -443,6 +450,7 @@
"in": "path",
"required": true,
"type": "string",
"minLength": 1,
"description": "The name of the resource group."
},
{
Expand Down Expand Up @@ -496,6 +504,7 @@
"in": "path",
"required": true,
"type": "string",
"minLength": 1,
"description": "The name of the resource group."
},
{
Expand All @@ -522,15 +531,15 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/resetServicePrincipalProfile":{
"post":{
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/resetServicePrincipalProfile": {
"post": {
"tags": [
"ManagedClusters"
],
"operationId": "ManagedClusters_ResetServicePrincipalProfile",
"summary": "Reset Service Principal Profile of a managed cluster.",
"description": "Update the service principal Profile for a managed cluster.",
"parameters":[
"parameters": [
{
"$ref": "#/parameters/ApiVersionParameter"
},
Expand All @@ -542,6 +551,7 @@
"in": "path",
"required": true,
"type": "string",
"minLength": 1,
"description": "The name of the resource group."
},
{
Expand All @@ -559,15 +569,15 @@
"$ref": "#/definitions/ManagedClusterServicePrincipalProfile"
},
"description": "Parameters supplied to the Reset Service Principal Profile operation for a Managed Cluster."
}
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/ManagedCluster"
}
},
},
"202": {
"description": "Accepted",
"schema": {
Expand All @@ -589,15 +599,15 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/resetAADProfile":{
"post":{
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/resetAADProfile": {
"post": {
"tags": [
"ManagedClusters"
],
"operationId": "ManagedClusters_ResetAADProfile",
"summary": "Reset AAD Profile of a managed cluster.",
"description": "Update the AAD Profile for a managed cluster.",
"parameters":[
"parameters": [
{
"$ref": "#/parameters/ApiVersionParameter"
},
Expand All @@ -609,6 +619,7 @@
"in": "path",
"required": true,
"type": "string",
"minLength": 1,
"description": "The name of the resource group."
},
{
Expand All @@ -626,7 +637,7 @@
"$ref": "#/definitions/ManagedClusterAADProfile"
},
"description": "Parameters supplied to the Reset AAD Profile operation for a Managed Cluster."
}
}
],
"responses": {
"200": {
Expand Down Expand Up @@ -654,7 +665,7 @@
"$ref": "./examples/ManagedClustersResetAADProfile.json"
}
}
}
}
}
},
"definitions": {
Expand Down Expand Up @@ -1079,7 +1090,7 @@
"$ref": "#/definitions/OSType",
"description": "OsType to be used to specify os type. Choose from Linux and Windows. Default to Linux."
},
"maxCount":{
"maxCount": {
"type": "integer",
"format": "int32",
"description": "Maximum number of nodes for auto-scaling"
Expand All @@ -1089,7 +1100,7 @@
"format": "int32",
"description": "Minimum number of nodes for auto-scaling"
},
"enableAutoScaling":{
"enableAutoScaling": {
"type": "boolean",
"description": "Whether to enable auto-scaler"
},
Expand All @@ -1105,7 +1116,7 @@
],
"description": "Profile for the container service agent pool."
},
"AgentPoolType":{
"AgentPoolType": {
"type": "string",
"enum": [
"VirtualMachineScaleSets",
Expand Down Expand Up @@ -1544,10 +1555,10 @@
},
"description": "OsType to be used to specify os type. Choose from Linux and Windows. Default to Linux."
},
"CredentialResults":{
"CredentialResults": {
"properties": {
"kubeconfigs": {
"type" : "array",
"type": "array",
"readOnly": true,
"items": {
"$ref": "#/definitions/CredentialResult"
Expand All @@ -1559,7 +1570,7 @@
"CredentialResult": {
"type": "object",
"properties": {
"name":{
"name": {
"type": "string",
"readOnly": true,
"description": "The name of the credential."
Expand Down
Loading

0 comments on commit a4368ac

Please sign in to comment.