-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat: Restoring old chats in chat module #1344
base: master
Are you sure you want to change the base?
Conversation
Next steps is to add a function to automatically store the thread id in the system and retrieve it next time onwards |
a988470
to
01ebf0b
Compare
This looks pretty good to me. As you say we need a way to either store the most recent thread's id in some persistent settings file or we need to be able to display a list of available threads to the user and let them pick one. Alternatively if we know which thread is the most recent we could just start using that one although it might be best to add a new menu item to "Continue from latest thread". Things could get interesting if one user has more than a single chat window open and tries to join the same thread from multiple chats but I think that's OK. I've discussed with @peterbarker recently about whether there is a way to store settings but I don't think MAVProxy has this ability at the moment. |
By the way, once we are closer to merging you might want to squash those two commits into a single commit. |
Ping @adityaomar3 - are you still interested in pursuing this one? |
Hi @peterbarker, Yes! I will be working on this feature, currently I am working on some other features in chat module itself but this is on my list, I will surely address this but a bit later. |
Added function to restore the old messages in chat module on submitting the correct assistant api key.
Currently it is in testing phase, we have to add thread_id manually, otherwise it will start new thread.
The demonstration is attached below.
test_chat_thread_restore.mp4