map: factor out methods for displaying vehicle on map #1407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably this removes the vehicle icon from the map when you change the map settings.
So if you
map set showgpspos 0
then the GPS icon will disappear, rather than just not be updated. Similary for ahrspos, simpos etc etc.This factoring should also allow us to add another map setting to add text to each icon to make it clear what it is representing, eg.