MAVProxy: fixed reconnection of serial port on windows after reboot #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not has any effect on linux MAVProxy, but allows Windows to reconnect after sending a reboot through console
|
Also, tested disconnect of USB in windows, and flight controller reconnects as expected. |
|
Merged, thanks! |
|
@joshanne great, thanks! |
|
@joshanne This is probably the best bug fix ever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line:
master.port.inWaiting()is causing a SerialException when a reboot is sent to the flight controller from the console.This change has been tested in windows and linux, it does not appear to have an effect on linux. The exception does not trigger in linux, but does on windows.