Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chat: Changed longitude is "lat" to longitude is "lon" #1433

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

ShashwathD
Copy link
Contributor

Previously said that lat was short for longitude, but I changed it to lon, which may fix some problems with the assistant when it comes to certain prompts from the user.

Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this!

One small thing is that the commit message should be prefixed with "chat:". We normally add a prefix of the subsystem (or directory) that has been changed because it makes backporting easier. If you have a peek at our recent commit list you'll see they all have a prefix

If you're not familiar with how to fix the commit I could do it for you

Thanks again!

@ShashwathD
Copy link
Contributor Author

ShashwathD commented Aug 5, 2024 via email

@ShashwathD ShashwathD changed the title Changed longitude is "lat" to longitude is "lon" chat: Changed longitude is "lat" to longitude is "lon" Aug 5, 2024
@ShashwathD
Copy link
Contributor Author

I added the chat: at the start, so should it work now?

@rmackay9
Copy link
Contributor

rmackay9 commented Aug 5, 2024

Hi @ShashwathD,

Thanks, it's not as easy as changing the PR title (which is what you've kindly updated). It's the commit title that we need to fix

@rmackay9
Copy link
Contributor

rmackay9 commented Aug 6, 2024

I've forced push to your branch now so this should be good to merge now, thanks!

@rmackay9 rmackay9 added the bug label Aug 6, 2024
@peterbarker peterbarker merged commit 29246e8 into ArduPilot:master Aug 6, 2024
2 checks passed
@peterbarker
Copy link
Contributor

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants