Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_ExternalAHRS: Compare FIX_TYPE judgment with definition name #23015

Conversation

muramura
Copy link
Contributor

I found GPS_FIX_TYPE compared to the direct value.
This value is defined.
I changed it to compare by definition name.

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable in that we're assigning from an enumeration elsewhere.

This doesn't seem reasonable in that we shouldn't be using a mavlink enumeration in here. We have AP_GPS::GPS_Status which could be used instead.

@khancyr
Copy link
Contributor

khancyr commented Mar 24, 2023

@peterbarker in fact the PR is correct, the driver already make use of mavlink enum for GPS and EKF. So I would say , let's just merge this and open an issue to remove the Mavlink dependencies

@peterbarker
Copy link
Contributor

I've created #28254 which doesn't extend our coupling with mavlink instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants