Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Baro: Add a step number to the message #25200

Conversation

muramura
Copy link
Contributor

@muramura muramura commented Oct 7, 2023

Append the step number to the message.
In the same message, it is unclear which process is being notified.

Copy link
Contributor

@magicrub magicrub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the 1 and 2 like that, it makes it look like it's baro1 or baro2 to the user. How about "... , step 1". I don't know if that's any better but I do agree you've found a confusing message that needs to have different text somehow

@khancyr
Copy link
Contributor

khancyr commented Oct 9, 2023

Don't agree, both loop are doing the same thing : getting data from the sensors. The only difference is that in first case, we discard it as we don't want the 1s data.
So if the data gathering failed in 1 or 2nd loop, that is the same

@peterbarker
Copy link
Contributor

Agree with @khancyr here - it doesn't really matter which loop we get this in. This will cost us bytes for no advantage.

Sorry, closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants