AP_Arming: Defined by the process used

[muramura]

The array of strings is far from the actual processing used.
Define this array in the process that will use it.

AFTER

[peterbarker]

@muramura you're right, but the definition is right next to the definition of the array we are iterating over.

This is purposeful, as you really don't want these arrays to be of different length! Note there's no assertion these are of the same length anywhere, so if you modify one you really do need to modify the other. Having them close together in the code helps that.

[khancyr]

adding a constant to remove the magic number would solve the size issue !

[WickedShell]

This seems less useful/more confusing. The only thing I'd actually really support here is a static assert that the arrays are the same length.

[magicrub]

I prefer it defined up where it is now but having all 3 using a define like @khancyr said is the better way to go.

[peterbarker]

Doesn't look like a lot of love for this rearrangement.

https://github.com/ArduPilot/ardupilot/pull/25207/files makes this no longer required. (we stop using indexes, rather a little structure to relate the channel with the name)

Closing this one - thanks anyway!