Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_GPS: allow logging of UBX-RXM-RTCM #26806

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

andyp1per
Copy link
Collaborator

No description provided.

@tridge
Copy link
Contributor

tridge commented Apr 17, 2024

nice! flight logs would be useful

@tridge tridge removed the DevCallEU label Apr 17, 2024
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main thing we need to verify is this quite extensive logging does actually find the issue. Then decide if it should be compiled in by default

libraries/AP_GPS/AP_GPS.cpp Outdated Show resolved Hide resolved
libraries/AP_GPS/AP_GPS.cpp Show resolved Hide resolved
libraries/AP_GPS/AP_GPS.cpp Show resolved Hide resolved
@peterbarker
Copy link
Contributor

Ping @andyp1per let's not forget this one

libraries/AP_GPS/AP_GPS_UBLOX.cpp Show resolved Hide resolved
libraries/AP_GPS/AP_GPS_UBLOX.cpp Outdated Show resolved Hide resolved
libraries/AP_GPS/AP_GPS_UBLOX.cpp Show resolved Hide resolved
@tridge
Copy link
Contributor

tridge commented Oct 9, 2024

I'm happy with the structure of this, just would like to know it had been tested with RTCM data but without this option set, should not log the data and should not make the GPS start sending the messages over the serial port

add logging of MSG_STATUS
configure via GPS_DRV_OPTIONS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants