-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copter: Grouping judgment conditions #26875
Copter: Grouping judgment conditions #26875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it but I would like to see the following line split out by removing the internal decision statement.
auto_yaw.set_yaw_angle_rate(yaw_cd * 0.01f, use_yaw_rate ? yaw_rate_cds * 0.01f : 0.0f);
65f2313
to
6fb655e
Compare
@lthall san. |
Sorry for the delay. Do you want to do a quick rebase and I will try to get it approved at the next dev call. |
6fb655e
to
c116fac
Compare
I'm not a great fan of this, but marking I've rebased it and I'm marking for DevCall. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me
It's correct but I think it's less easy to understand after the change. I think with two of us not liking the change I think I'll close it |
Multiple IF statements contain the same decision condition.
I have grouped the judgment conditions.