-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hwdef: remove MatekL431-Periph #27659
hwdef: remove MatekL431-Periph #27659
Conversation
this was a kitchen-sink AP_Periph build. We're moving away from these. This board does not currently build. We could make it build, but it will die again and again.
this was a kitchen-sink AP_Periph build. We're moving away from these. This board does not currently build. We could make it build, but it will die again and again.
Doesn't compile, out of flash space, this seems an obvious canddate
In fairness the MatekL431 node is a kitchen sink kind of board. I will miss this build dearly 😭 Why is a speedybee change mixed in? |
That is for this board: This build is recommended on there page? I have used these a lot. Typically as a base with extra stuff added on, relay temp sensors ect. I think we should fix it rather than removing. Maybe remove GPS, I think remote GPS via a external node is not common. |
Yes, agreed |
I looked and it does seem GPS changes are what pushed it over the edge. Can we just remove some of the rarer GPS types? It does have a GPS plug and a GPS is a suggested application. But maybe we could push users to the GPS-specific build for that. |
#27685 will bring this build back from the dead without any hwdef changes. |
+1 for keeping this build around. As Pete mentioned, that board is a kitchen sink board. I tend to rely on the base hwdef to customise this board. Edit: Tested @tpwrules changes, and MatekL431 is brought back to life. |
You can drop GSOF from periph on this board as long as we still check GSOF on Periph. |
OK, obviously a lot of love for the MatekL431-Periph build. Lesson learnt :-) |
this was a kitchen-sink AP_Periph build. We're moving away from these.
This board does not currently build. We could make it build, but it will die again and again.