AP_DroneCAN: DNAServer: don't "allocate" broadcast ID #28049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not necessary and wastes flash.
tpwrules
force-pushed
the
pr/dna-alloc-cleanup
branch
from
adc1499
to
b10860f
Compare
While technically legal, it's unlikely to have been tested and an allocatee might do silly things. Also makes the logic a bit more clear and improves the failure message.
tpwrules
force-pushed
the
pr/dna-alloc-cleanup
branch
from
b10860f
to
b9d68aa
Compare
tridge
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While technically legal, it's unlikely to have been tested and an allocatee might do silly things.
Also makes the logic a bit more clear, improves the failure message, and some other minor savings.
Tested on CubeOrange (with artificially limited DNA database size) and a pile of MatekL431 boards. Saves a couple hundred bytes.