Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VectorNav: rename dataflash log message names #28069

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

weavVN
Copy link
Contributor

@weavVN weavVN commented Sep 10, 2024

Change the DataFlash log message names in the VectorNav external AHRS driver to make the log messages better indicate they are from the VectorNav driver.

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've fixed the commit message up and will mark for MergeOnCIPass.

Note our usage of "dataflash" is generally incorrect and a bad habit we're all trying to break. You're not helping :-)

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Sep 11, 2024

Good improvement. The VN prefix is yours for the taking :)

@peterbarker peterbarker merged commit e5f4f87 into ArduPilot:master Sep 12, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants