Speedybee f405wing with bidirectional dshot #28070
Conversation
you can get the data of the esc temperature and rmp using bidirectional-dshot on Bluejay firmware.
There was a problem hiding this comment.
This shouldn't be copying all of the non-bdshot variant sideways - use the include mechanisms to re-use the existing board.
No need to copy the documentation.
Check the MatekF765-Wing-bdshot as an example of what this PR should look like.
Also please note that this should be a single commit with a title of something like,:
hwdef: create SpeedyBeeF405-bdshot variant
|
ok, but it's compiling and working ) |
There was a problem hiding this comment.
Close now.
Please note that this should be a single commit.
We have a document here on how to clean up the commits to a mergeable state: https://ardupilot.org/dev/docs/git-interactive-rebase.html
If you don't feel confident doing those cleanup, just let me know and I'll do them before merge.
| # WS2812 LED | ||
| NTF_LED_LEN,4 | ||
| SERVO12_FUNCTION,120 | ||
|
|
||
| #Serial Port defaults | ||
| SERIAL1_PROTOCOL 23 | ||
| SERIAL4_PROTOCOL -1 | ||
| SERIAL6_PROTOCOL 2 |
There was a problem hiding this comment.
| # WS2812 LED | |
| NTF_LED_LEN,4 | |
| SERVO12_FUNCTION,120 | |
| #Serial Port defaults | |
| SERIAL1_PROTOCOL 23 | |
| SERIAL4_PROTOCOL -1 | |
| SERIAL6_PROTOCOL 2 | |
| @include ../SpeedyBeeF405WING/defaults.parm |
| # hw definition file for processing by chibios_pins.py | ||
| # for SpeedyBeeF405WING bootloader | ||
|
|
||
| include ../SpeedyBeeF405WING/hwdef-bl.dat |
There was a problem hiding this comment.
Remove this file and the compiled bootloader (you've done well in this PR if you were creating an entirely new board, BTW - but you're not :-)
| @@ -0,0 +1,10 @@ | |||
| # Bi-directional dshot version of SpeedyBeeF405WING | |||
|
|
|||
| include ../SpeedyBeeF405WING/hwdef.dat | |||
There was a problem hiding this comment.
| include ../SpeedyBeeF405WING/hwdef.dat | |
| include ../SpeedyBeeF405WING/hwdef.dat | |
| USE_BOOTLOADER_FROM_BOARD SpeedyBeeF405WING |
Sure. But you do realise "it compiles, ship it!" was a meme back in the day, right? :-) |
| SERIAL4_PROTOCOL -1 | ||
| SERIAL6_PROTOCOL 2 | ||
|
|
||
| #dshot-bidir |
There was a problem hiding this comment.
I don't think you should be setting any of these. This could be used on a quadplane, etc, etc. Best to let the user configure them.
| include ../SpeedyBeeF405WING/hwdef.dat | ||
| undef PB6 PB0 PC8 PC9 | ||
|
|
||
| PB6 TIM4_CH1 TIM4 PWM(2) GPIO(51) BIDIR |
There was a problem hiding this comment.
Did you check the DMA allocation here?
There was a problem hiding this comment.
As far as I can tell you don't lose anything with this config so why not just support it in the main firmware?
There was a problem hiding this comment.
absolutely...should be a change to the existing hwdef instead of new target
There was a problem hiding this comment.
because i send to speedebee a version of the firmware for them, and also a modified source code for their target. and they answered month ago "..We have scheduled the testing of this target for next week. Following the successful completion of these tests, we intend to submit the target to the ArduPilot developers for approval.." and as a result, a month passed, no movement. Every time I download the source code of a stable new version, compile the firmware, and post it in my group (and as I understand, people using it), I got tired of it, it’s easier to have the ability to update via MP right away.
There was a problem hiding this comment.
Did you check the DMA allocation here?
as an example I took an almost complete copy of matek405wing-bdshot
and there was:
# Bi-directional dshot version of MatekF405
include ../MatekF405-Wing/hwdef.dat
undef PB7 PB6 PB0 PB1 PC8 PC9
PB7 TIM4_CH2 TIM4 PWM(1) GPIO(50)
PB6 TIM4_CH1 TIM4 PWM(2) GPIO(51) BIDIR
PB0 TIM3_CH3 TIM3 PWM(3) GPIO(52) BIDIR
PB1 TIM3_CH4 TIM3 PWM(4) GPIO(53)
# Can only do bdshot on M1-4, so give up DMA channel on M5/M6 to get full DMA on USART3
PC8 TIM8_CH3 TIM8 PWM(5) GPIO(54) NODMA
PC9 TIM8_CH4 TIM8 PWM(6) GPIO(55) NODMA
DMA_NOSHARE TIM3_UP
| include ../SpeedyBeeF405WING/hwdef.dat | ||
| undef PB6 PB0 PC8 PC9 | ||
|
|
||
| PB6 TIM4_CH1 TIM4 PWM(2) GPIO(51) BIDIR |
There was a problem hiding this comment.
absolutely...should be a change to the existing hwdef instead of new target
|
Thanks guys for helping. Also thanks, now I understand how to use GitHub to add changes to different projects)) |
When compiling, it was error something about long name. |
you can get the data of the esc temperature and rmp using bidirectional-dshot on Bluejay firmware.
…etupfpv/ardupilot into SpeedyBeeF405WING-with-bd-shot
…ub.com/setupfpv/ardupilot into SpeedyBeeF405WING-with-bd-shot" This reverts commit c293eea, reversing changes made to 2a0bab0.
No description provided.