-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plane: added Q_APPROACH_DIST #28072
Plane: added Q_APPROACH_DIST #28072
Conversation
This seems like a good idea, but the interaction with the Q_OPTIONS is very confusing. If I understand this correctly, DISABLE_APPROACH actually means disable fixed wing approach, is that right? and if so the new behavior seems to be: 16: Disable Approach - always disable use of fixed wing approach and airbrake stages in VTOL landing, overriding Q_APPROACH_DIST if set Do I have that right? |
// @Range: 0.0 1000 | ||
// @Increment: 1 | ||
// @User: Standard | ||
AP_GROUPINFO("APPROACH_DIST", 39, QuadPlane, approach_distance, 0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it's a bit of a mouthful, we already have Q_FW_LND_APR_RAD - so for consistency, it might make sense to call this Q_FW_LND_APR_DST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q_FW_LND_APR_RAD is related to the circle before transition into the wind stuff. Its not the same thing.
this sets a minimum distance to use the fixed wing approach logic. It is an alternative to just disabling the approach with Q_OPTIONS which some users do to avoid some short distance problems. This allows the approach to still be used for longer distances in QRTL but have it disabled for shorter distances
33418bf
to
f45158e
Compare
@tridge does this impact the code that prevents switch to fw approach if in vtol closer than 1.5x maxrad? I assume not.. |
this sets a minimum distance to use the fixed wing approach logic. It is an alternative to just disabling the approach with Q_OPTIONS which some users do to avoid some short distance problems. This allows the approach to still be used for longer distances in QRTL but have it disabled for shorter distances
The approach code is really needed for longer distances to allow the full fixed wing terrain following logic to be used