AP_MSP: MSP_RAW_GPS cog should be decidegrees not centidegrees #28090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catkira
force-pushed
the
fix_msp_raw_gps_cog
branch
from
dc8f395
to
d76b94f
Compare
|
I think we should also make ground_course_dd uint16_t, because the range is 0 - 3600 deci-degrees. |
|
Looks likely. Commit message should be |
|
I can fix. Should I also change it to uint16_t? (-> see my last force push) |
catkira
force-pushed
the
fix_msp_raw_gps_cog
branch
from
d76b94f
to
d5a7551
Compare
amilcarlucas
suggested changes
Sep 12, 2024
| @@ -217,7 +217,7 @@ void AP_MSP_Telem_Backend::update_gps_state(gps_state_t &gps_state) | |||
| gps_state.lon = loc.lng; | |||
| gps_state.alt_m = loc.alt/100; // 1m resolution | |||
| gps_state.speed_cms = gps.ground_speed() * 100; | |||
| gps_state.ground_course_cd = gps.ground_course_cd(); | |||
| gps_state.ground_course_dd = gps.ground_course_cd() * 10; | |||
There was a problem hiding this comment.
To convert from centi-degrees to deci-degrees you need to divide by 10
catkira
force-pushed
the
fix_msp_raw_gps_cog
branch
2 times, most recently
from
94f25fc
to
90e5e1a
Compare
catkira
force-pushed
the
fix_msp_raw_gps_cog
branch
from
90e5e1a
to
4dca1b1
Compare
peterbarker
requested changes
Sep 12, 2024
|
@rmackay9 can you backport this to plane 4.5.6 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
source: http://www.multiwii.com/wiki/index.php?title=Multiwii_Serial_Protocol