Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copter: don't pass channel_yaw->norm_input_dz() into get_pilot_desired_yaw_rate #28155

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Copter: don't pass channel_yaw->norm_input_dz() into get_pilot_desired_yaw_rate #28155

merged 1 commit into from
Sep 21, 2024

Conversation

IamPete1
Copy link
Member

We always pass the same value into the function so we can move the getting of the value down.

rmackay9
rmackay9 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

probably goes without saying but of course, give it a quick test at least to be sure it's OK

@IamPete1
Copy link
Member Author

probably goes without saying but of course, give it a quick test at least to be sure it's OK

Yeah, yaw still works in SITL.

@rmackay9 rmackay9 merged commit a72182a into ArduPilot:master Sep 21, 2024
75 checks passed
@rmackay9
Copy link
Contributor

Thanks, let's get this out of the way before our dev call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmackay9 rmackay9 rmackay9 approved these changes

Assignees
No one assigned
Labels
Copter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IamPete1 @rmackay9