Utilities broken out of the fast rate PR #28240
Open
+468
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
reviewed
Sep 26, 2024
| rate switch utility. This helps to compare different tunes in-flight to compare performance | ||
| --]] | ||
|
|
||
| ---@diagnostic disable: param-type-mismatch |
There was a problem hiding this comment.
This is cheating. What is the error?
There was a problem hiding this comment.
I think I just copied this from somewhere else!
IamPete1
reviewed
Sep 26, 2024
| -- shorten pname to fit with X_ prefix | ||
| local short_name = string.sub(name, math.max(1, 1 + string.len(name) - (16 - string.len(PARAM_BACKUP_TABLE_PREFIX)))) | ||
| assert(param:add_param(PARAM_BACKUP_TABLE_KEY, idx, short_name, default_value), string.format('could not add param %s', short_name)) | ||
| local p = bind_param(PARAM_BACKUP_TABLE_PREFIX .. short_name) |
There was a problem hiding this comment.
Suggested change
| local p = bind_param(PARAM_BACKUP_TABLE_PREFIX .. short_name) | |
| local p = Parameter(PARAM_BACKUP_TABLE_PREFIX .. short_name) |
I suspect this will fix the warning. You can remove the bind_param helper.
IamPete1
reviewed
Sep 26, 2024
| -- add a parameter and bind it to a variable | ||
| function bind_add_param(name, idx, default_value) | ||
| assert(param:add_param(PARAM_TABLE_KEY, idx, name, default_value), string.format('could not add param %s', name)) | ||
| local p = bind_param(PARAM_TABLE_PREFIX .. name) |
There was a problem hiding this comment.
Suggested change
| local p = bind_param(PARAM_TABLE_PREFIX .. name) | |
| local p = Parameter(PARAM_TABLE_PREFIX .. name) |
IamPete1
reviewed
Sep 26, 2024
| -- when we fault we run the update function again after 1s, slowing it | ||
| -- down a bit so we don't flood the console with errors | ||
| --return protected_wrapper, 1000 | ||
| return |
There was a problem hiding this comment.
If you just return here you might as well not bother with the protected_wrapper at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.