Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split sending terrain report from terrain request #28244

Merged

Conversation

peterbarker
Copy link
Contributor

Someone tried to set the streamrate of the reporting with set-message-interval.

That doesn't work in master, but you can get that effect by setting the itnerval on the terrain-request.

That's kind of garbage, so split the sending of reports away from requests.

@peterbarker peterbarker force-pushed the pr/split-terrain-report-request branch 3 times, most recently from bbad6f3 to c4c37c8 Compare September 27, 2024 03:04
@peterbarker
Copy link
Contributor Author

Tested in SITL.

At the moment the streamrate doesn't really work well for the terrain request - there are internal timing limitations in TerrainGCS which stop that working well. We should probably remove the internal timing limits within TerrainGCS and ensure that the streamrate for requesting data from the GCS is appropriate (0.5Hz?!). There's also the fact we'll request at arbitrary rate when we've lost our location to look at.

In any case, this moves us towards tidying the terrain-request timing stuff as the user might want to get TERRAIN_REPORT.current_height at a high rate.

@Georacer
Copy link
Contributor

I was recently playing with this and in stock SITL I was getting a TERRAIN_REPORT regularly at 4Hz.
I traced it and I think it is always streamed with _EXTRA3, contrary to the description of that parameter.

@tridge tridge merged commit bdecbb5 into ArduPilot:master Oct 1, 2024
95 checks passed
@peterbarker peterbarker deleted the pr/split-terrain-report-request branch October 1, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants