Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS_MAVLink: add warning if guided-mode-mission-requests are used #28494

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

peterbarker
Copy link
Contributor

image

@peterbarker peterbarker force-pushed the pr/mission-request-removeal-warning branch 4 times, most recently from 37c1869 to 639c20d Compare October 29, 2024 15:02
@peterbarker
Copy link
Contributor Author

###### Enabling GUIDED_MISSION_REQUESTS(HAL_GCS_GUIDED_MISSION_REQUESTS_ENABLED) on copter costs -600 bytes
###### Enabling GUIDED_MISSION_REQUESTS(HAL_GCS_GUIDED_MISSION_REQUESTS_ENABLED) on plane costs -552 bytes
###### Enabling GUIDED_MISSION_REQUESTS(HAL_GCS_GUIDED_MISSION_REQUESTS_ENABLED) on rover costs -496 bytes
###### Enabling GUIDED_MISSION_REQUESTS(HAL_GCS_GUIDED_MISSION_REQUESTS_ENABLED) on antennatracker costs -432 bytes
###### Enabling GUIDED_MISSION_REQUESTS(HAL_GCS_GUIDED_MISSION_REQUESTS_ENABLED) on sub costs -536 bytes
###### Enabling GUIDED_MISSION_REQUESTS(HAL_GCS_GUIDED_MISSION_REQUESTS_ENABLED) on blimp costs -432 bytes

@tridge
Copy link
Contributor

tridge commented Nov 5, 2024

@peterbarker we discussed on the dev call and think we can just remove support now for 4.7

@rmackay9
Copy link
Contributor

rmackay9 commented Nov 5, 2024

I think we should just remove the code. Our mavlink interface wiki page spells out much better ways to achieve the same thing

Another option would be to merge this to 4.6 and then remove the code from master (aka 4.7) almost immediately

@peterbarker
Copy link
Contributor Author

I think we should just remove the code. Our mavlink interface wiki page spells out much better ways to achieve the same thing

Insta-breaking people's setups isn't a great idea IMO. Removing this code would insta-break all existing MAVProxy installs, for example.

Another option would be to merge this to 4.6 and then remove the code from master (aka 4.7) almost immediately

That would be nice!

@peterbarker peterbarker force-pushed the pr/mission-request-removeal-warning branch from 639c20d to c09231b Compare November 13, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants