XSD: WIP tags in enums #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amilcarlucas Can we get this in? It makes sense unless we decide we don't want WIP at all. |
|
Looks good to me. @tridge can I merge this? |
amilcarlucas
approved these changes
Nov 22, 2021
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enums can also be work in progress. This enables them to be marked as such.
Further, this allows a "since" attribute to be added to the wip tag (but does not mandate it). The idea is that since allows you to easily see when the WIP tag was created, and thereby more easily assess whether the tag should be removed (or the whole element if implementation did not end up happening)
FYI @amilcarlucas - as per discussion in mavlink/mavlink#1732 (comment)