Mavgen WLua: Support 64-bit flag fields #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- includes a new test case for AUTOPILOT_VERSION message - Note that due to Wireshark limitation this fix will only work while bitfields are not using the high 32-bits - this is the case for all current messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Wireshark errors when decoding messages containing 64-bit bitmask/flag fields (fix #852).
Note that as per the notes I previously wrote in the issue, there is a wireshark limitation on the use of Uint64s meaning that this fix will only work while Mavlink bitfields do not make use of the high-32-bits.
This is currently OK for the only 2 messages using 64-bit bitfields (AUTOPILOT_VERSION and GENERATOR_STATUS)
I have also created a test case using a PCAP file containing an AUTOPILOT_VERSION message.