Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use pytest<=7.4.4 as 8.0.0 will not run the tests #918

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

shancock884
Copy link
Contributor

As of approx 06/02/2024, the pytest part of pymavlink CI began failing on Python v3.8+. This appears to be because pytest 8.0.0 is now being used as opposed to 7.4.4 before.
For now, this PR offers a fix, by pegging the version at <=7.4.4 in requirements.txt.
(Note that we need to use "<=" as Python 3.5 is using an older version of pytest).

For info, the error message when using pytest 8.0.0 was:

_____________________ ERROR collecting tests/test_trim.py ______________________
ImportError while importing test module '/home/runner/work/pymavlink/pymavlink/tests/test_trim.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
E   ModuleNotFoundError: No module named 'pymavlink.tests'

@shancock884
Copy link
Contributor Author

FYI @peterbarker

@peterbarker peterbarker merged commit 664f165 into ArduPilot:master Feb 10, 2024
12 checks passed
@peterbarker
Copy link
Contributor

Merged, thanks!

@shancock884 shancock884 deleted the pytest-7-4-4 branch February 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants