Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: input-fee component #521

Merged
merged 10 commits into from
Mar 12, 2020
Merged

refactor: input-fee component #521

merged 10 commits into from
Mar 12, 2020

Conversation

luciorubeens
Copy link
Contributor

@luciorubeens luciorubeens commented Mar 11, 2020

Summary

Remove business logic from component and add tests.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. Status: In Progress The issue or pull request is being worked on. labels Mar 11, 2020
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #521 into develop will increase coverage by 2.16%.
The diff coverage is 47.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #521      +/-   ##
==========================================
+ Coverage     5.05%   7.21%   +2.16%     
==========================================
  Files           94      97       +3     
  Lines         5148    4946     -202     
  Branches      1090    1021      -69     
==========================================
+ Hits           260     357      +97     
+ Misses        4878    4569     -309     
- Partials        10      20      +10
Impacted Files Coverage Δ
...components/input-currency/input-currency.module.ts 100% <ø> (ø)
src/app/directives/directives.module.ts 100% <ø> (ø)
...pages/delegates/delegate-detail/delegate-detail.ts 0% <0%> (ø) ⬆️
src/app/services/ark-api/ark-api.ts 5.12% <0%> (-0.38%) ⬇️
...s/transaction/transaction-send/transaction-send.ts 0% <0%> (ø) ⬆️
...ponents/input-currency/input-currency.component.ts 75.55% <100%> (+75.55%) ⬆️
...rc/app/components/input-fee/input-fee.component.ts 100% <100%> (+100%) ⬆️
...ves/paste-clipboard-value/paste-clipboard-value.ts 50% <50%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a521b...77067f7. Read the comment docs.

@luciorubeens luciorubeens marked this pull request as ready for review March 11, 2020 16:59
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Mar 11, 2020
Copy link
Contributor

@clucasalcantara clucasalcantara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! :3 (animations for the win!) 🏆 🌮

I only left one comment about the ESLint config for the prettier plugin 👌 This is more a question than a change request but I'm feeling that we removed a prop that shouldn't be removed, Could you please take a look? 😃

.eslintrc.json Outdated Show resolved Hide resolved
@luciorubeens
Copy link
Contributor Author

@clucasalcantara Good catch! Fixed.

Copy link
Contributor

@clucasalcantara clucasalcantara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🌞! Now seems fine :3

Good job, man!🏅 🏆

@luciorubeens luciorubeens merged commit 2cb3a9a into develop Mar 12, 2020
@ghost ghost deleted the refactor/input-fee branch March 12, 2020 14:36
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants