-
Notifications
You must be signed in to change notification settings - Fork 100
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #521 +/- ##
==========================================
+ Coverage 5.05% 7.21% +2.16%
==========================================
Files 94 97 +3
Lines 5148 4946 -202
Branches 1090 1021 -69
==========================================
+ Hits 260 357 +97
+ Misses 4878 4569 -309
- Partials 10 20 +10
Continue to review full report at Codecov.
|
82d7bdc
to
d89c201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! :3 (animations for the win!) 🏆 🌮
I only left one comment about the ESLint config for the prettier plugin 👌 This is more a question than a change request but I'm feeling that we removed a prop that shouldn't be removed, Could you please take a look? 😃
@clucasalcantara Good catch! Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🌞! Now seems fine :3
Good job, man!🏅 🏆
Summary
Remove business logic from component and add tests.
Checklist