Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--split-opa does not work properly with QUnit v1 #96

Closed
ArnaudBuchholz opened this issue Jul 2, 2024 · 2 comments
Closed

--split-opa does not work properly with QUnit v1 #96

ArnaudBuchholz opened this issue Jul 2, 2024 · 2 comments

Comments

@ArnaudBuchholz
Copy link
Owner

The moduleId is not exposed (it gives null). It should be replaced with module name. Yet, some escaping is required
@ArnaudBuchholz
Copy link
Owner Author

When moduleId is not present, we need to use module name.
It also changes the parameter : it should be module and not moduleId
Furthermore, QUnit changes the location with an escaped version of the module name (spaces are replaced with +).
This breaks the test recognition

ArnaudBuchholz added a commit that referenced this issue Jul 2, 2024
@ArnaudBuchholz
test: adding e2e reproducing issue #96
021ca8d
ArnaudBuchholz added a commit that referenced this issue Jul 2, 2024
@ArnaudBuchholz
fix(probe): handle QUnit v1 modules (#96)
7e2af45
ArnaudBuchholz added a commit that referenced this issue Jul 3, 2024
@ArnaudBuchholz
fix(qunit-hooks): filters out unwanted modules (#96)
ecc523e
ArnaudBuchholz added a commit that referenced this issue Jul 4, 2024
@ArnaudBuchholz
fix(post): remembers initial URL (#96)
e56a35b
@ArnaudBuchholz
Copy link
Owner Author

5.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ArnaudBuchholz