Fix borderRadius display error when there is only 2 options #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eHammarstrom
suggested changes
Aug 3, 2017
| @@ -120,7 +120,7 @@ class SegmentedControls extends React.Component { | |||
| borderBottomRightRadius: adjustedBorderRadius | |||
| } | |||
| } | |||
| if (index === this.props.options.length - 2) { | |||
There was a problem hiding this comment.
Simply changing if to else if solves the problem. The additional conditional does not seem necessary.
There was a problem hiding this comment.
@eHammarstrom when this fix going to be merged?
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When thers is only 2 options, this brancn condition will break first option's borderRadius props, this new condition will fix this, but made no seprator between two options. Consider in most scene one of the option will always be seleced, this side effect can be accepted.