Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor alias module; Use HashSet to store RetAlias #61

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

WIZeaz
Copy link
Contributor

@WIZeaz WIZeaz commented Oct 17, 2024

This PR includes:

  • feat: remove the millisecond format in the log. Now the date format in logging is %H:%M:%S".
  • feat: change the log level from INFO to DEBUG in the alias module. Remove redundant logging messages.
  • feat: use std::collections::HashSet to store RetAlias so we can prevent duplicate aliases from the result.
  • refactor: fix most of the cargo clippy warnings in the alias module.

@hxuhack hxuhack merged commit 909f7a6 into Artisan-Lab:main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants