-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional AVIF support #116
Conversation
Closing and re-opening to trigger a re-build. |
I think you are missing Meson, Ninja and NASM.
|
@paolobarbolini thanks for your help! I'll see if I get it to work on ubuntu and macos |
Note that I disabled the |
I can make a PR to this repo when I get the chance to also add it to the libavif-rs CI |
@paolobarbolini I'm not sure what this means. Could you explain? |
After writing the Windows CI steps for the libavif-rs repo I'll also open a PR for this one, since the CI configuration is very similar between the two repositories. |
Update: I started working on the Windows support njaard/libavif-rs#15 but at the moment it's not working for some reason. |
I love to hear that @paolobarbolini! Unfortunately I don't have much time for open source development but I can see that the relevant PR (njaard/libavif-rs#18) was merged so updating the libavif-rs dependency should be done for Emulsion but I'm not sure when will I get to it. |
Windows support will come out in the v0.3 release. At the moment there aren't any breaking changes in the Your CI isn't currently testing AVIF on Windows, and that will require the Windows job to be updated to install the libavif required build dependencies (build dependencies | tests), but that can be done later. |
This adds optional support for AVIF files. It can be enabled with
--features=avif
. Note that it requirescmake
.I can confirm that it works on Arch Linux. You can test if it works on your platform with this file: avif.zip
There's a tracking issue for AVIF support in
image-rs
, but that's unlikely to be implemented soon (image-rs
only accepts pure Rust codecs).If you don't think adding this is a good idea, feel free to close this PR.