feat: Update create service account token method

ArunaStorage · Jun 30, 2023 · 123d11d · 123d11d
1 parent e027fb3
commit 123d11d
Showing 1 changed file with 19 additions and 16 deletions.
diff --git a/aruna/api/storage/services/v1/service_account_service.proto b/aruna/api/storage/services/v1/service_account_service.proto
@@ -45,10 +45,10 @@ service ServiceAccountService {
     };
   }
 
-  // EditServiceAccountPermission
+  // SetServiceAccountPermission
   //
   // Overwrites the project specific permissions for a service account
-  rpc EditServiceAccountPermission(EditServiceAccountPermissionRequest) returns (EditServiceAccountPermissionResponse){
+  rpc SetServiceAccountPermission(SetServiceAccountPermissionRequest) returns (SetServiceAccountPermissionResponse){
     option (google.api.http) = {
       put : "/v1/service_account/{svc_account_id}/permissions"
       body : "*"
@@ -132,33 +132,36 @@ message CreateServiceAccountResponse {
 }
 
 message CreateServiceAccountTokenRequest {
-    // Empty if token should inherit account / project permissions
     string svc_account_id = 1;
-    // Collection id
-    string collection_id = 2;
-    // Token name
-    string name = 3;
-    // Token expiry
-    google.protobuf.Timestamp expires_at = 4;
-    // Token permissions
-    storage.models.v1.Permission permission = 5;
+    // Identify the associated project (should always be provided)
+    string project_id = 2;
+    // Collection id, will be empty if permission should be on project level
+    string collection_id = 3;
+    // (optional) Token name
+    string name = 4;
+    // (optional) Token expiry 
+    google.protobuf.Timestamp expires_at = 5;
+    // Token permissions, must be less than or equal user permissions
+    storage.models.v1.Permission permission = 6;
 }
 
 message CreateServiceAccountTokenResponse {
     // This contains only the token description
     storage.models.v1.Token token = 1;
-    // This is the actual secret token
-    // Attention, this can not be recreated and needs to be stored securely
-    // New tokens will always contain a new secret
+    // This is the actual secret API token
     string token_secret = 2;
+    // S3 Access Key
+    string s3_access_key = 3;
+    // S3 Secret Key
+    string s3_secret_key = 4;
 }
 
-message EditServiceAccountPermissionRequest {
+message SetServiceAccountPermissionRequest {
     string svc_account_id = 1;
     storage.models.v1.Permission new_permission = 2;
 }
 
-message EditServiceAccountPermissionResponse {
+message SetServiceAccountPermissionResponse {
     ServiceAccount service_account = 1;
 }