Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Update svc account handling from dev #84

Merged
merged 2 commits into from
Jun 30, 2023
Merged

[feat] Update svc account handling from dev #84

merged 2 commits into from
Jun 30, 2023

Conversation

St4NNi
Copy link
Member

@St4NNi St4NNi commented Jun 30, 2023 •
edited
Loading

This PR updates the service account handling. Especially the token creation process.

Changes

  • Result token + s3 credentials similar to regular users
  • Add project_id to create token request to allow for double checks for privilege escalations / correct project
  • Remove UNFINISHED annotation
  • Rename EditServiceAccountPermissions to SetServiceAccountPermissions to make it clear that this overwrites the previous setting

lfbrehm
lfbrehm approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@lfbrehm lfbrehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@St4NNi St4NNi merged commit 7fce8ce into main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfbrehm lfbrehm lfbrehm approved these changes

@das-Abroxas das-Abroxas Awaiting requested review from das-Abroxas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@St4NNi @lfbrehm